Issue 2812020: [Mac] Convert the nib file on disk over to a xib format instead....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2812020: [Mac] Convert the nib file on disk over to a xib format instead.... (Closed)

Created:
10 years, 6 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Convert the nib file on disk over to a xib format instead. BUG=38443 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50592

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2073 lines, -2058 lines)			Patch
A	webkit/tools/test_shell/mac/English.lproj/MainMenu.xib	View	1 2	1 chunk	+2072 lines, -0 lines	0 comments	Download
D	webkit/tools/test_shell/mac/English.lproj/MainMenu.nib/designable.nib	View		1 chunk	+0 lines, -2057 lines	0 comments	Download
D	webkit/tools/test_shell/mac/English.lproj/MainMenu.nib/keyedobjects.nib	View		Binary file		0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/2812020/diff/1/4 File webkit/tools/test_shell/mac/English.lproj/MainMenu.xib (right): http://codereview.chromium.org/2812020/diff/1/4#newcode5 webkit/tools/test_shell/mac/English.lproj/MainMenu.xib:5: <string key="IBDocument.SystemVersion">10F569</string> Got a 10.5 box you can ...

10 years, 6 months ago (2010-06-23 13:55:32 UTC) #2

LGTM

Expand Messages | Collapse Messages

Issue 2812020: [Mac] Convert the nib file on disk over to a xib format instead.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages