Issue 2812003: TTF: Re-enable test that rely on ClickModalDialogButton since it is now...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2812003: TTF: Re-enable test that rely on ClickModalDialogButton since it is now... (Closed)

Created:
10 years, 6 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, James Hawkins

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

TTF: Re-enable tests that rely on ClickModalDialogButton since it is now supported on Mac. BUG=45031 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49969

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -27 lines)			Patch
	M	chrome/browser/unload_uitest.cc	View	1 2	5 chunks	+11 lines, -27 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

On 2010/06/16 00:51:56, Chris Silverberg wrote: > Waiting to kick off try-bot runs once tree ...

10 years, 6 months ago (2010-06-16 01:15:26 UTC) #2

James Hawkins

http://codereview.chromium.org/2812003/diff/3001/1003 File chrome/browser/unload_uitest.cc (right): http://codereview.chromium.org/2812003/diff/3001/1003#newcode284 chrome/browser/unload_uitest.cc:284: // Fails sometimes on Linux valgrind. nit: This block ...

10 years, 6 months ago (2010-06-16 01:17:56 UTC) #3

csilv

10 years, 6 months ago (2010-06-16 01:26:37 UTC) #4

LGTM, thanks!

Expand Messages | Collapse Messages

Issue 2812003: TTF: Re-enable test that rely on ClickModalDialogButton since it is now... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages