Sandbox warmup - localtime().

Sandbox warmup - localtime().

[brettw, 2009-02-25 18:00:20]

http://codereview.chromium.org/28120/diff/6/7
File chrome/renderer/renderer_main_platform_delegate_mac.mm (right):

http://codereview.chromium.org/28120/diff/6/7#newcode50
Line 50: // Warm up localtime().
I don't understand why this is here at all, and your comment doesn't help. Can
you elaborate?

[pink (ping after 24hrs), 2009-02-25 18:22:28]

LGTM, though I agree with Brett that a little better commenting that the bulk of
the work in this function is done to initialize various subsystems before the
sandbox goes into effect would be helpful to those who are unfamiliar with our
setup routines.

[John Grabowski, 2009-02-25 18:29:47]

http://codereview.chromium.org/28120/diff/6/7
File chrome/renderer/renderer_main_platform_delegate_mac.mm (right):

http://codereview.chromium.org/28120/diff/6/7#newcode51
Line 51: time_t tv = {0};
I think I understand why the warm-up (sandbox so we want locale files), but I
don't see why time(NULL) --> {0} is desired.

[John Grabowski, 2009-02-25 18:40:20]

LGTM to get localtime() there.