Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Issue 28119: Chromium changes to use new WebKit, WebKitClient, and WebClipboard interfaces... (Closed)

Created:
11 years, 9 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chromium changes to use new WebKit, WebKitClient, and WebClipboard interfaces. A new WebKitClientImpl class is added to webkit/glue that consumers can use to help implement WebKitClient. In the future, consumers will likely subclass WebKitClientImpl. For now, that is not necessary. Since a WebImage may not hold a SkBitmap, I needed to modify ScopedClipboardWriterGlue to not deal in SkBitmaps. So, I just added a WriteBitmapFromPixels method in place of the WriteBitmap method. That method is actually named the same as the one from the base class, which is perhaps kind of nice since the purpose of ScopedClipboardWriterGlue is to override the default way of sending an image to the clipboard! R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10416

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -159 lines) Patch
M chrome/chrome.xcodeproj/project.pbxproj View 9 chunks +87 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/renderer.vcproj View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/renderer_glue.cc View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M webkit/build/WebKit/SConscript View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M webkit/build/WebKit/WebKit.vcproj View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
M webkit/build/WebKit/WebKit.vsprops View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/SConscript View 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 1 2 4 chunks +0 lines, -115 lines 0 comments Download
M webkit/glue/glue.vcproj View 1 2 3 4 chunks +18 lines, -2 lines 0 comments Download
M webkit/glue/scoped_clipboard_writer_glue.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/simple_clipboard_impl.cc View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
A webkit/glue/webclipboard_impl.h View 1 chunk +34 lines, -0 lines 0 comments Download
A webkit/glue/webclipboard_impl.cc View 1 chunk +134 lines, -0 lines 0 comments Download
A webkit/glue/webkit_client_impl.h View 1 chunk +26 lines, -0 lines 0 comments Download
A webkit/glue/webkit_client_impl.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj View 7 chunks +8 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.vcproj View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_tests.vcproj View 1 2 4 chunks +14 lines, -14 lines 0 comments Download
M webkit/webkit.xcodeproj/project.pbxproj View 11 chunks +48 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
I'm working on making this compile on Mac and Linux. Meanwhile, I think it is ...
11 years, 9 months ago (2009-02-25 18:08:59 UTC) #1
dglazkov
11 years, 9 months ago (2009-02-25 19:05:39 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698