SPDY sends RST_STREAM upon cancelling request, or bad header parse data.

SPDY sends RST_STREAM upon cancelling request, or bad header parse data.
Also fix tsan failure for spdy_http_stream_unittest.
Attempted to commit in http://codereview.chromium.org/3014030/show, ran into
different tsan failure.
TEST=net_unittests, tsan on windows for SpdyHttpStreamTest.
BUG=46589, 47478, 50198
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53829

[erikchen, 2010-07-27 00:28:37]

Everything except for spdy_http_stream_unittest was already reviewed in
http://codereview.chromium.org/3014030/show.
While I've wasn't been able to legitimately repro the windows tsan bug the prior
cl ran into, I did recreate it by changing some code around. The same error
occurs if the MockReads data socket has an outstanding IO_PENDING read, and that
read gets used on a read callback. I've changed the test so that there are no
outstanding reads - this should fix the problem.

[lzheng, 2010-07-27 05:28:58]

http://codereview.chromium.org/2811072/diff/1/3
File net/spdy/spdy_http_stream_unittest.cc (right):

http://codereview.chromium.org/2811072/diff/1/3#newcode55
net/spdy/spdy_http_stream_unittest.cc:55: MockRead reads[] = {
Can you comment how and where these three reads are triggered?

[erikchen, 2010-07-27 16:38:31]

http://codereview.chromium.org/2811072/diff/1/3
File net/spdy/spdy_http_stream_unittest.cc (right):

http://codereview.chromium.org/2811072/diff/1/3#newcode55
net/spdy/spdy_http_stream_unittest.cc:55: MockRead reads[] = {
On 2010/07/27 05:28:58, lzheng wrote:
> Can you comment how and where these three reads are triggered?

callback.WaitForResult() triggers the MockWrite, and reads 2 & 3.
data->completeread() triggers read 4.

[lzheng1, 2010-07-27 17:29:42]

On Tue, Jul 27, 2010 at 9:38 AM, <erikchen@chromium.org> wrote:

>
> http://codereview.chromium.org/2811072/diff/1/3
> File net/spdy/spdy_http_stream_unittest.cc (right):
>
> http://codereview.chromium.org/2811072/diff/1/3#newcode55
> net/spdy/spdy_http_stream_unittest.cc:55: MockRead reads[] = {
> On 2010/07/27 05:28:58, lzheng wrote:
>
>> Can you comment how and where these three reads are triggered?
>>
>
> callback.WaitForResult() triggers the MockWrite, and reads 2 & 3.
> data->completeread() triggers read 4.
>
> Cool. Could you add these comments around line 79?

Thanks.


>
> http://codereview.chromium.org/2811072/show
>

[erikchen, 2010-07-27 17:32:57]

done
On 2010/07/27 17:29:42, lzheng1 wrote:
> On Tue, Jul 27, 2010 at 9:38 AM, <mailto:erikchen@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/2811072/diff/1/3
> > File net/spdy/spdy_http_stream_unittest.cc (right):
> >
> > http://codereview.chromium.org/2811072/diff/1/3#newcode55
> > net/spdy/spdy_http_stream_unittest.cc:55: MockRead reads[] = {
> > On 2010/07/27 05:28:58, lzheng wrote:
> >
> >> Can you comment how and where these three reads are triggered?
> >>
> >
> > callback.WaitForResult() triggers the MockWrite, and reads 2 & 3.
> > data->completeread() triggers read 4.
> >
> > Cool. Could you add these comments around line 79?
> 
> Thanks.
> 
> 
> >
> > http://codereview.chromium.org/2811072/show
> >
>

[lzheng, 2010-07-27 17:38:25]

LGTM.

On 2010/07/27 17:32:57, erikchen1 wrote:
> done
> On 2010/07/27 17:29:42, lzheng1 wrote:
> > On Tue, Jul 27, 2010 at 9:38 AM, <mailto:erikchen@chromium.org> wrote:
> > 
> > >
> > > http://codereview.chromium.org/2811072/diff/1/3
> > > File net/spdy/spdy_http_stream_unittest.cc (right):
> > >
> > > http://codereview.chromium.org/2811072/diff/1/3#newcode55
> > > net/spdy/spdy_http_stream_unittest.cc:55: MockRead reads[] = {
> > > On 2010/07/27 05:28:58, lzheng wrote:
> > >
> > >> Can you comment how and where these three reads are triggered?
> > >>
> > >
> > > callback.WaitForResult() triggers the MockWrite, and reads 2 & 3.
> > > data->completeread() triggers read 4.
> > >
> > > Cool. Could you add these comments around line 79?
> > 
> > Thanks.
> > 
> > 
> > >
> > > http://codereview.chromium.org/2811072/show
> > >
> >