Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2811057: Update inheritance hierarchy in Objects.h to better reflect the actual hierar... (Closed)

Created:
10 years, 5 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Update inheritance hierarchy in Objects.h to better reflect the actual hierarchy. We do not have a GlobalContext class. We do, however, have a SerializedScopeInfo class that inherits FixedArray. Starting comment is also slightly misleading, since not all objects in the hierarchy is described in objects.h (e.g., Context is described in contexts.h). Committed: http://code.google.com/p/v8/source/detail?r=5101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/objects.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
10 years, 5 months ago (2010-07-20 06:36:56 UTC) #1
Mads Ager (chromium)
10 years, 5 months ago (2010-07-20 07:00:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698