Add ability to limit when context menu items appear with url patterns....

Add ability to limit when context menu items appear with url patterns.

BUG=408198
TEST=Extensions context menu API should work with changes described.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52867

[asargent_no_longer_on_chrome, 2010-07-15 22:41:10]

Aaron - FYI, I made the document and target url patterns arrays of strings
instead of a single string, so that you can specify multiple patterns that would
match for a single item.

[Aaron Boodman, 2010-07-16 00:37:16]

Per offline, I think it would be good to use URLPattern instead of pure globs.

http://codereview.chromium.org/2811049/diff/9001/10009
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/2811049/diff/9001/10009#newcode282
chrome/renderer/resources/extension_process_bindings.js:282:
onclick.apply(onclick, arguments);
the second "onclick" should be "null".

[asargent_no_longer_on_chrome, 2010-07-16 18:22:52]

Switched to using URLPattern's.

http://codereview.chromium.org/2811049/diff/9001/10009
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/2811049/diff/9001/10009#newcode282
chrome/renderer/resources/extension_process_bindings.js:282:
onclick.apply(onclick, arguments);
On 2010/07/16 00:37:16, Aaron Boodman wrote:
> the second "onclick" should be "null".

Done.

[asargent_no_longer_on_chrome, 2010-07-16 20:32:06]

Per offline dicsussion, switched to using ExtensionExtent instead of
URLPatternList.

[Aaron Boodman, 2010-07-16 23:30:49]

lgtm

http://codereview.chromium.org/2811049/diff/39001/36008
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/2811049/diff/39001/36008#newcode2557
chrome/common/extensions/api/extension_api.json:2557: "description": "Lets you
restrict the item to only apply to documents whose URL matches one of the given
patterns. (This applies to frames as well). The patterns use the same format as
the 'matches' part of the content declaration in an extension manifest. See the
'Match Patterns' reference for more details."
Nit: I think you can remove the sentence beginning with "the patterns use the
same format...". You can also hyperlink 'Match Patterns' to the page in
question. Search this file for '<a' for an example.