Group plugins in about:plugins and show update link for out-of-date ones.

Group plugins in about:plugins and show update link for out-of-date ones.

Re-landing patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>;

Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.

BUG=3910, 47858
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Also, if the internal PDF plugin is enabled, it should stay enabled after a restart.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51510

[Bernhard Bauer, 2010-06-30 13:26:24]

Please review (again :-) )

The only change to the last version is in chrome/browser/plugin_updater.cc, line
452, which should fix bug 47585.

[viettrungluu, 2010-06-30 14:03:10]

lgtm

http://codereview.chromium.org/2811037/diff/1/6
File chrome/browser/plugin_updater.cc (right):

http://codereview.chromium.org/2811037/diff/1/6#newcode452
chrome/browser/plugin_updater.cc:452: if (plugin->GetString(L"path", &path)) {
Oops. I must have missed that in rebasing at some point.

[arv (Not doing code reviews), 2010-06-30 17:11:05]

FYI

http://codereview.chromium.org/2811037/diff/1/9
File chrome/browser/resources/plugins.html (right):

http://codereview.chromium.org/2811037/diff/1/9#newcode223
chrome/browser/resources/plugins.html:223: padding-left: 1em;
rtl?

You can use -webkit-padding-start instead.

http://codereview.chromium.org/2811037/diff/1/9#newcode292
chrome/browser/resources/plugins.html:292: { 'name': 'Group Name',
new line after { here

http://codereview.chromium.org/2811037/diff/1/9#newcode407
chrome/browser/resources/plugins.html:407: function handleEnablePlugin(node,
enable, is_group) {
no underscores in JS

http://codereview.chromium.org/2811037/diff/1/9#newcode436
chrome/browser/resources/plugins.html:436: return !!plugin.version &&
plugin.version != "0";
Use single quotes for strings

[Bernhard Bauer, 2010-07-02 09:26:46]

On 2010/06/30 17:11:05, arv wrote:
> FYI
> 
> http://codereview.chromium.org/2811037/diff/1/9
> File chrome/browser/resources/plugins.html (right):
> 
> http://codereview.chromium.org/2811037/diff/1/9#newcode223
> chrome/browser/resources/plugins.html:223: padding-left: 1em;
> rtl?
> 
> You can use -webkit-padding-start instead.
> 
> http://codereview.chromium.org/2811037/diff/1/9#newcode292
> chrome/browser/resources/plugins.html:292: { 'name': 'Group Name',
> new line after { here
> 
> http://codereview.chromium.org/2811037/diff/1/9#newcode407
> chrome/browser/resources/plugins.html:407: function handleEnablePlugin(node,
> enable, is_group) {
> no underscores in JS
> 
> http://codereview.chromium.org/2811037/diff/1/9#newcode436
> chrome/browser/resources/plugins.html:436: return !!plugin.version &&
> plugin.version != "0";
> Use single quotes for strings

All done. Committing the latest version.