Issue 2811023: Make the location bar generate accessibility extension API events...

Issue 2811023: Make the location bar generate accessibility extension API events... (Closed)

Created:
10 years, 6 months ago by dmazzoni

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the location bar generate accessibility extension API events on linux/views. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51124

Patch Set 3 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -20 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/accessibility_event_router_gtk.h	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/accessibility_event_router_gtk.cc	View	1	8 chunks	+70 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/accessible_widget_helper_gtk.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/accessible_view_helper.h	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/views/accessible_view_helper.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1	3 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/views/location_bar/location_bar_view.h	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/location_bar/location_bar_view.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/2811023/diff/1/5 File chrome/browser/gtk/accessible_widget_helper_gtk.cc (right): http://codereview.chromium.org/2811023/diff/1/5#newcode21 chrome/browser/gtk/accessible_widget_helper_gtk.cc:21: DCHECK(profile_); if a NULL value for profile_ would ...

10 years, 6 months ago (2010-06-22 22:36:26 UTC) #2

dmazzoni

10 years, 6 months ago (2010-06-23 02:31:40 UTC) #3

On Tue, Jun 22, 2010 at 3:36 PM, <estade@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/2811023/diff/1/5
> File chrome/browser/gtk/accessible_widget_helper_gtk.cc (right):
>
> http://codereview.chromium.org/2811023/diff/1/5#newcode21
> chrome/browser/gtk/accessible_widget_helper_gtk.cc:21: DCHECK(profile_);
> if a NULL value for profile_ would cause a crash down the line (as it
> looks like it might), then this should be a CHECK(). (no D)


Good idea, done.

Thanks.
- Dominic



>
> http://codereview.chromium.org/2811023/show
>

Expand Messages | Collapse Messages