Issue 2811013: Mac: Infrastructure for serialization of OS fonts over IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2811013: Mac: Infrastructure for serialization of OS fonts over IPC. (Closed)

Created:
10 years, 6 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit), agl

CC:
chromium-reviews

Visibility:
Public.

Description

Mac: Infrastructure for serialization of OS fonts over IPC. Renderer & Browser bits to send and receive IPC message for OOP font loading. BUG=29729 TEST=All unit tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50321

Patch Set 1 #

Patch Set 2 : Minor fixes #

Patch Set 3 : Fix more style errors. #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -12 lines)			Patch
M	chrome/browser/renderer_host/resource_message_filter.h	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View	1	5 chunks	+30 lines, -1 line	1 comment	Download
M	chrome/renderer/renderer_webkitclient_impl.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/renderer/renderer_webkitclient_impl.cc	View	1 2	4 chunks	+34 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jeremy

This CL depends on https://bugs.webkit.org/show_bug.cgi?id=40544 which should hopefully land shortly.

10 years, 6 months ago (2010-06-17 11:35:19 UTC) #1

agl

10 years, 6 months ago (2010-06-17 13:52:28 UTC) #2

LGTM

http://codereview.chromium.org/2811013/diff/7001/8001
File chrome/browser/renderer_host/resource_message_filter.cc (right):

http://codereview.chromium.org/2811013/diff/7001/8001#newcode781
chrome/browser/renderer_host/resource_message_filter.cc:781:
font_data.GiveToProcess(base::GetCurrentProcessHandle(), handle);
Although this works, it looks a bit odd: "Give to process: me" :)

Since this is OS_MACOSX, it's fine to say
handle->fd = font_data.handle()
handle->auto_close = true;
font_data.Unmap();

It saves a dup() too.

Expand Messages | Collapse Messages