Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2811011: Fixed extension sync crasher (Closed)

Created:
10 years, 6 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, ncarter (slow), idana, Erik does not do reviews, ben+cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Fixed Extension change-handling methods to avoid unrecoverable errors/crashes on adding new extensions with extensions sync turned on. BUG=46742 TEST=manual, trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/browser/sync/glue/extension_model_associator.cc View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
akalin
+nick for review
10 years, 6 months ago (2010-06-16 23:55:14 UTC) #1
ncarter (slow)
LGTM. The code reads a little odd now, but I can live with it.
10 years, 6 months ago (2010-06-17 01:04:16 UTC) #2
akalin
10 years, 6 months ago (2010-06-17 01:59:02 UTC) #3
On 2010/06/17 01:04:16, nick wrote:
> LGTM.
> 
> The code reads a little odd now, but I can live with it.

Yeah, I'll send out a CL to make the code clearer.  I wanted to do it in this
CL, but it ended up snowballing and I decided to split it up into a "quick fix"
and a more thorough refactoring.

Powered by Google App Engine
This is Rietveld 408576698