Issue 2811006: Always report keypresses in plugins as handled on the Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2811006: Always report keypresses in plugins as handled on the Mac (Closed)

Created:
10 years, 6 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, John Grabowski, jam, pam+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Always report keypresses in plugins as handled on the Mac This matches the behavior of other Mac browsers; until the new Advanced Key Handling spec is implemented by plugins and Chromium, the return value for key events can't be trusted to be meaningful. BUG=42490 TEST=Typing should still work in plugins. Pressing delete in a Silverlight text field shouldn't go back in history. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49812

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	webkit/glue/plugins/webplugin_delegate_impl_mac.mm	View		1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages