Implement accelerators in the gtk port.

chrome/browser/tab_contents/web_contents_view_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/web_contents_view_gtk.h"
 
+#include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 
 #include "base/gfx/point.h"
 #include "base/gfx/rect.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/renderer_host/render_widget_host_view_gtk.h"
 #include "chrome/browser/tab_contents/web_contents.h"
 
+#include "webkit/glue/webinputevent.h"
+
 namespace {
 
 // Callback used in WebContentsViewGtk::CreateViewForWidget().
 void RemoveWidget(GtkWidget* widget, void* container) {
   gtk_container_remove(GTK_CONTAINER(container), widget);
 }
 
 }  // namespace
 
 // static
@@ skipping 84 matching lines @@
 
 void WebContentsViewGtk::UpdateDragCursor(bool is_drop_target) {
   NOTIMPLEMENTED();
 }
 
 void WebContentsViewGtk::TakeFocus(bool reverse) {
   NOTIMPLEMENTED();
 }
 
 void WebContentsViewGtk::HandleKeyboardEvent(const WebKeyboardEvent& event) {
-  // The renderer returned a keyboard event it did not process. This may be
-  // a keyboard shortcut that we have to process.
-  // The windows code forwards this event onwards to accelerator handling,
-  // and then to DefWindowProc.  TODO(port): should do something similar.
-  NOTIMPLEMENTED();
+  // The renderer returned a keyboard event it did not process. This may be a
+  // keyboard shortcut that we have to process or a cursor key/page up/down
+  // etc.
+  switch (event.gdk_keyval) {
+    case GDK_Page_Up:
+    case GDK_Page_Down:
+    case GDK_Left:
+    case GDK_Right:
+    case GDK_Up:
+    case GDK_Down:
+      NOTIMPLEMENTED()
+          << "Need better navigation support in HandleKeyboardEvent";
+      break;
+    default:
+      // This may be an accelerator. Pass it on to GTK.
+      gtk_accel_groups_activate(G_OBJECT(vbox_->window),
+                                event.gdk_keyval,
+                                GdkModifierType(event.gdk_modifier));
+  }

[Avi (use Gerrit), 2009/02/25 22:38:40]

No. Handling random crap that the renderer sends back is a security hole. It's
wrong on Windows (and we're going to fix it) and it's wrong here. We need to
keep a copy of the original event on the browser side somewhere. We cannot rely
on the renderer. Let's fix it everywhere at once.

 }
 
 void WebContentsViewGtk::OnFindReply(int request_id,
                                      int number_of_matches,
                                      const gfx::Rect& selection_rect,
                                      int active_match_ordinal,
                                      bool final_update) {
   NOTIMPLEMENTED();
 }
 
@@ skipping 26 matching lines @@
     bool user_gesture) {
   NOTIMPLEMENTED();
 }
 
 void WebContentsViewGtk::ShowCreatedWidgetInternal(
     RenderWidgetHostView* widget_host_view,
     const gfx::Rect& initial_pos) {
   NOTIMPLEMENTED();
 }