Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: git-cl-upload-hook

Issue 281007: Fixes based on maruel's comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git-cl-upload-hook
===================================================================
--- git-cl-upload-hook (revision 29156)
+++ git-cl-upload-hook (working copy)
@@ -8,7 +8,7 @@
# Try locating depot_tools from the user's PATH.
depot_tools_path = None
-for path in os.environ.get("PATH").split(':'):
+for path in os.environ.get("PATH").split(os.pathsep):
if not path.endswith("depot_tools"):
continue
depot_tools_path = path
@@ -26,8 +26,7 @@
try:
import git_cl_hooks
except ImportError:
- print ("ERROR: Could not import git_cl_hooks from your depot_tools at %s." %
- depot_tools_path)
+ print "ERROR: Could not import git_cl_hooks from depot_tools in your PATH."
print "ERROR: Make sure %s is up-to-date and try again." % depot_tools_path
sys.exit(1)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698