Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 2810027: Fix error in for-in on x64 platform using full compiler with keyed store IC.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/mjsunit/for-in.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1500 matching lines...) Expand 10 before | Expand all | Expand 10 after
1511 __ pop(rax); // Restore value. 1511 __ pop(rax); // Restore value.
1512 __ Move(rcx, prop->key()->AsLiteral()->handle()); 1512 __ Move(rcx, prop->key()->AsLiteral()->handle());
1513 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize)); 1513 Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
1514 __ call(ic, RelocInfo::CODE_TARGET); 1514 __ call(ic, RelocInfo::CODE_TARGET);
1515 __ nop(); // Signal no inlined code. 1515 __ nop(); // Signal no inlined code.
1516 break; 1516 break;
1517 } 1517 }
1518 case KEYED_PROPERTY: { 1518 case KEYED_PROPERTY: {
1519 __ push(rax); // Preserve value. 1519 __ push(rax); // Preserve value.
1520 VisitForValue(prop->obj(), kStack); 1520 VisitForValue(prop->obj(), kStack);
1521 VisitForValue(prop->key(), kStack); 1521 VisitForValue(prop->key(), kAccumulator);
1522 __ movq(rax, Operand(rsp, 2 * kPointerSize)); 1522 __ movq(rcx, rax);
1523 __ pop(rdx);
1524 __ pop(rax);
1523 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize)); 1525 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
1524 __ call(ic, RelocInfo::CODE_TARGET); 1526 __ call(ic, RelocInfo::CODE_TARGET);
1525 __ nop(); // Signal no inlined code. 1527 __ nop(); // Signal no inlined code.
1526 __ Drop(3); // Receiver, key, and extra copy of value.
1527 break; 1528 break;
1528 } 1529 }
1529 } 1530 }
1530 } 1531 }
1531 1532
1532 1533
1533 void FullCodeGenerator::EmitVariableAssignment(Variable* var, 1534 void FullCodeGenerator::EmitVariableAssignment(Variable* var,
1534 Token::Value op, 1535 Token::Value op,
1535 Expression::Context context) { 1536 Expression::Context context) {
1536 // Left-hand sides that rewrite to explicit property accesses do not reach 1537 // Left-hand sides that rewrite to explicit property accesses do not reach
(...skipping 1703 matching lines...) Expand 10 before | Expand all | Expand 10 after
3240 __ ret(0); 3241 __ ret(0);
3241 } 3242 }
3242 3243
3243 3244
3244 #undef __ 3245 #undef __
3245 3246
3246 3247
3247 } } // namespace v8::internal 3248 } } // namespace v8::internal
3248 3249
3249 #endif // V8_TARGET_ARCH_X64 3250 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/for-in.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698