Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2810002: Added HostConfig class. Changed SimpleHost to use it. (Closed)

Created:
10 years, 6 months ago by Sergey Ulanov
Modified:
9 years, 7 months ago
Reviewers:
dmac, Alpha Left Google
CC:
chromium-reviews, Sergey Ulanov, dmac, awong, garykac, Alpha Left Google
Visibility:
Public.

Description

Added HostConfig class. Changed SimpleHost to use it. BUG=none TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49852

Patch Set 1 : - #

Total comments: 4

Patch Set 2 : - #

Patch Set 3 : refcounting #

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -28 lines) Patch
M remoting/host/chromoting_host.h View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/chromoting_host.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M remoting/host/heartbeat_sender.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A remoting/host/host_config.h View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M remoting/host/simple_host_process.cc View 1 2 3 2 chunks +14 lines, -7 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergey Ulanov
10 years, 6 months ago (2010-06-14 19:14:07 UTC) #1
Alpha Left Google
small nits, otherwise LGTM. http://codereview.chromium.org/2810002/diff/2001/1009 File remoting/host/heartbeat_sender.h (right): http://codereview.chromium.org/2810002/diff/2001/1009#newcode28 remoting/host/heartbeat_sender.h:28: void Start(JingleClient* jingle_client, const HostConfig* ...
10 years, 6 months ago (2010-06-14 20:26:06 UTC) #2
Sergey Ulanov
http://codereview.chromium.org/2810002/diff/2001/1009 File remoting/host/heartbeat_sender.h (right): http://codereview.chromium.org/2810002/diff/2001/1009#newcode28 remoting/host/heartbeat_sender.h:28: void Start(JingleClient* jingle_client, const HostConfig* config); On 2010/06/14 20:26:06, ...
10 years, 6 months ago (2010-06-14 20:43:20 UTC) #3
Alpha Left Google
10 years, 6 months ago (2010-06-15 01:11:49 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698