Issue 2809048: RegExp replace with empty string optimization by Sandholm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2809048: RegExp replace with empty string optimization by Sandholm. (Closed)

Created:
10 years, 5 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

RegExp replace with empty string optimization by Sandholm.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+155 lines, -5 lines)			Patch
M	src/codegen.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.h	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+140 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 5 months ago (2010-07-05 11:58:22 UTC) #2

LGTM.

http://codereview.chromium.org/2809048/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/2809048/diff/1/4#newcode2360
src/runtime.cc:2360: if (start == end && ++next > length) break;
Side effects in condition, after shortcutting logical and, is too tricky.

Expand Messages | Collapse Messages