Make vboot_reference build in MSVC command line environment.

Make vboot_reference build in MSVC command line environment.

This is a mostly NOOP change which modifies the source code
to compile cleanly in the MSVC command line build
environment.

A new makefile is introduced (msc/nmakefile) along with a
README.txt in the same directory explaining how to build
the code in the DOS window. As of this submission the build
is running in a 32 bit environment, the intention is to use
the same makefile for 64 bit builds in the future.

Enabling high compilation warnings level allowed to
identify a couple of bugs in the code which are being fixed.

Not all sources are being compiled in the MSVC environment, 
only those in firmware/ and most of those in test/
subdirectories. The benchmark calculations require porting
of the timer facilities and are being postponed.

TEST

Built in DOS and linux environments. Ran unit tests in 
linux environment.

[gauravsh, 2010-06-24 18:42:36]

Drive by...

http://codereview.chromium.org/2809037/diff/2002/8008
File firmware/lib/rollback_index.c (right):

http://codereview.chromium.org/2809037/diff/2002/8008#newcode20
firmware/lib/rollback_index.c:20: #pragma warning (disable: 4127)
comment?

http://codereview.chromium.org/2809037/diff/2002/8008#newcode374
firmware/lib/rollback_index.c:374: #pragma warning (disable: 4100)
ditto

http://codereview.chromium.org/2809037/diff/2002/8009
File firmware/lib/vboot_kernel.c (right):

http://codereview.chromium.org/2809037/diff/2002/8009#newcode111
firmware/lib/vboot_kernel.c:111: #pragma warning(disable: 4127)
can you add a comment describing what this pragma does?

http://codereview.chromium.org/2809037/diff/2002/8023
File tests/cgptlib_test.c (right):

http://codereview.chromium.org/2809037/diff/2002/8023#newcode15
tests/cgptlib_test.c:15: #include "test_common.h"
nit: alpha order

http://codereview.chromium.org/2809037/diff/2002/8025
File tests/crc32_test.c (right):

http://codereview.chromium.org/2809037/diff/2002/8025#newcode8
tests/crc32_test.c:8: #include "test_common.h"
nit: alphabetical order

[vb, 2010-06-24 19:16:14]

Added comments to all cases where pragmas are used and modified the order of
includes.

http://codereview.chromium.org/2809037/diff/2002/8008
File firmware/lib/rollback_index.c (right):

http://codereview.chromium.org/2809037/diff/2002/8008#newcode20
firmware/lib/rollback_index.c:20: #pragma warning (disable: 4127)
On 2010/06/24 18:42:36, gauravsh wrote:
> comment?

Done.

http://codereview.chromium.org/2809037/diff/2002/8008#newcode374
firmware/lib/rollback_index.c:374: #pragma warning (disable: 4100)
On 2010/06/24 18:42:36, gauravsh wrote:
> ditto

Done.

http://codereview.chromium.org/2809037/diff/2002/8009
File firmware/lib/vboot_kernel.c (right):

http://codereview.chromium.org/2809037/diff/2002/8009#newcode111
firmware/lib/vboot_kernel.c:111: #pragma warning(disable: 4127)
On 2010/06/24 18:42:36, gauravsh wrote:
> can you add a comment describing what this pragma does?

Done.

http://codereview.chromium.org/2809037/diff/2002/8023
File tests/cgptlib_test.c (right):

http://codereview.chromium.org/2809037/diff/2002/8023#newcode15
tests/cgptlib_test.c:15: #include "test_common.h"
On 2010/06/24 18:42:36, gauravsh wrote:
> nit: alpha order

Done.

http://codereview.chromium.org/2809037/diff/2002/8025
File tests/crc32_test.c (right):

http://codereview.chromium.org/2809037/diff/2002/8025#newcode8
tests/crc32_test.c:8: #include "test_common.h"
On 2010/06/24 18:42:36, gauravsh wrote:
> nit: alphabetical order

Done.

[gauravsh, 2010-06-24 19:20:32]

Thanks! LGTM if wfrichar/rspangler are ok with this too.

On 2010/06/24 19:16:14, vb wrote:
> Added comments to all cases where pragmas are used and modified the order of
> includes.
> 
> http://codereview.chromium.org/2809037/diff/2002/8008
> File firmware/lib/rollback_index.c (right):
> 
> http://codereview.chromium.org/2809037/diff/2002/8008#newcode20
> firmware/lib/rollback_index.c:20: #pragma warning (disable: 4127)
> On 2010/06/24 18:42:36, gauravsh wrote:
> > comment?
> 
> Done.
> 
> http://codereview.chromium.org/2809037/diff/2002/8008#newcode374
> firmware/lib/rollback_index.c:374: #pragma warning (disable: 4100)
> On 2010/06/24 18:42:36, gauravsh wrote:
> > ditto
> 
> Done.
> 
> http://codereview.chromium.org/2809037/diff/2002/8009
> File firmware/lib/vboot_kernel.c (right):
> 
> http://codereview.chromium.org/2809037/diff/2002/8009#newcode111
> firmware/lib/vboot_kernel.c:111: #pragma warning(disable: 4127)
> On 2010/06/24 18:42:36, gauravsh wrote:
> > can you add a comment describing what this pragma does?
> 
> Done.
> 
> http://codereview.chromium.org/2809037/diff/2002/8023
> File tests/cgptlib_test.c (right):
> 
> http://codereview.chromium.org/2809037/diff/2002/8023#newcode15
> tests/cgptlib_test.c:15: #include "test_common.h"
> On 2010/06/24 18:42:36, gauravsh wrote:
> > nit: alpha order
> 
> Done.
> 
> http://codereview.chromium.org/2809037/diff/2002/8025
> File tests/crc32_test.c (right):
> 
> http://codereview.chromium.org/2809037/diff/2002/8025#newcode8
> tests/crc32_test.c:8: #include "test_common.h"
> On 2010/06/24 18:42:36, gauravsh wrote:
> > nit: alphabetical order
> 
> Done.

[Bill Richardson, 2010-06-24 19:29:47]

I really dislike seeing raw pragmas, even if we tell the compiler to ignore
them. Vadim says the M$ compiler can use __pragma() instead of #pragma, allowing
__pragma to be #defined away. I'd much prefer that syntax if possible.

If it's not possible, I suppose this is okay. It's ugly, though. :-)

[Luigi Semenzato, 2010-06-24 20:29:52]

Is there an agreement that this code may be compiled on Windows, but not edited?

If someone changes this code on Windows and then commits it, the version hash
will not get updated, and this could cause all sort of confusion.  It must be
clear that this code *requires* a local build (not just an emerge) on linux
before committing.

To make it editable on Windows, the nmakefile must contain the linux Makefile
code that updates version.c (or at least put a random number in it, or a date)

[vb, 2010-06-24 20:51:07]

Luigi, the intention is to be able to run test cases in Windows environment,
all the development will be always happening in Linux, because the code must
be compilable and runnable on Linux as well.

cheers,
/v



On Thu, Jun 24, 2010 at 1:29 PM, <semenzato@chromium.org> wrote:

> Is there an agreement that this code may be compiled on Windows, but not
> edited?
>
> If someone changes this code on Windows and then commits it, the version
> hash
> will not get updated, and this could cause all sort of confusion.  It must
> be
> clear that this code *requires* a local build (not just an emerge) on linux
> before committing.
>
> To make it editable on Windows, the nmakefile must contain the linux
> Makefile
> code that updates version.c (or at least put a random number in it, or a
> date)
>
>
>
> http://codereview.chromium.org/2809037/show
>

[Randall Spangler, 2010-06-24 21:31:47]

I agree it'd be preferable to use __pragma() instead of #pragma, with
sysincludes defining that to nothing for gcc.

LGTM other than that.

Thanks
 -R