Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 2809032: Take survival rates of young objects into account when choosing old generation limits. (Closed)

Created:
10 years, 6 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Take survival rates of young objects into account when choosing old generation limits. Stable high survival rates of young objects both during partial and full collection indicate that mutator is either building or modifying a structure with a long lifetime. In this case we aggressively raise old generation memory limits to postpone subsequent mark-sweep collection and trade memory space for the mutation speed. Committed: http://code.google.com/p/v8/source/detail?r=4938

Patch Set 1 #

Total comments: 4

Patch Set 2 : throttle down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -0 lines) Patch
M src/heap.h View 1 2 chunks +51 lines, -0 lines 0 comments Download
M src/heap.cc View 1 4 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Chromium)
10 years, 6 months ago (2010-06-23 12:30:08 UTC) #1
Mads Ager (chromium)
I think we need to have a strategy for throttling down again before landing this ...
10 years, 6 months ago (2010-06-24 10:35:01 UTC) #2
Vyacheslav Egorov (Chromium)
http://codereview.chromium.org/2809032/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/2809032/diff/1/2#newcode666 src/heap.cc:666: old_gen_promotion_limit_ *= 2; On 2010/06/24 10:35:02, Mads Ager wrote: ...
10 years, 6 months ago (2010-06-24 11:08:33 UTC) #3
Mads Ager (chromium)
10 years, 6 months ago (2010-06-24 11:38:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698