Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/arm/assembler-arm.cc

Issue 2809029: Lower waste from alignment of deferred code blocks. (Closed)
Patch Set: Remove alignment of deferred code on all platforms. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 388
389 void Assembler::Align(int m) { 389 void Assembler::Align(int m) {
390 ASSERT(m >= 4 && IsPowerOf2(m)); 390 ASSERT(m >= 4 && IsPowerOf2(m));
391 while ((pc_offset() & (m - 1)) != 0) { 391 while ((pc_offset() & (m - 1)) != 0) {
392 nop(); 392 nop();
393 } 393 }
394 } 394 }
395 395
396 396
397 void Assembler::CodeTargetAlign() { 397 void Assembler::CodeTargetAlign() {
398 Align(16); // Tentative value. 398 // Preferred alignment of jump targets on some ARM chips.
399 Align(8);
399 } 400 }
400 401
401 402
402 bool Assembler::IsNop(Instr instr, int type) { 403 bool Assembler::IsNop(Instr instr, int type) {
403 // Check for mov rx, rx. 404 // Check for mov rx, rx.
404 ASSERT(0 <= type && type <= 14); // mov pc, pc is not a nop. 405 ASSERT(0 <= type && type <= 14); // mov pc, pc is not a nop.
405 return instr == (al | 13*B21 | type*B12 | type); 406 return instr == (al | 13*B21 | type*B12 | type);
406 } 407 }
407 408
408 409
(...skipping 1975 matching lines...) Expand 10 before | Expand all | Expand 10 after
2384 2385
2385 // Since a constant pool was just emitted, move the check offset forward by 2386 // Since a constant pool was just emitted, move the check offset forward by
2386 // the standard interval. 2387 // the standard interval.
2387 next_buffer_check_ = pc_offset() + kCheckConstInterval; 2388 next_buffer_check_ = pc_offset() + kCheckConstInterval;
2388 } 2389 }
2389 2390
2390 2391
2391 } } // namespace v8::internal 2392 } } // namespace v8::internal
2392 2393
2393 #endif // V8_TARGET_ARCH_ARM 2394 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698