Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2809017: Fix ShutdownTest flakiness by opening tabs one at a time. (Closed)

Created:
10 years, 6 months ago by Patrick Horn
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Paweł Hajdan Jr., TVL, huanr, michaeln
Visibility:
Public.

Description

Fix ShutdownTest flakiness by opening tabs one at a time. BUG=46609 TEST=startup_tests should no longer flake out as much Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50174

Patch Set 1 #

Patch Set 2 : Removed extra enum #

Patch Set 3 : retry upload #

Total comments: 4

Patch Set 4 : Add enum comment and assert #

Total comments: 1

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M chrome/test/startup/shutdown_test.cc View 1 2 3 4 5 chunks +28 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Patrick Horn
This should fix flakiness on the shutdown tests by opening tabs one at a time, ...
10 years, 6 months ago (2010-06-17 02:00:22 UTC) #1
Lei Zhang
I think this is just avoiding the underlying problem. A user should be able to ...
10 years, 6 months ago (2010-06-17 02:31:44 UTC) #2
Patrick Horn
On 2010/06/17 02:31:44, Lei Zhang wrote: > I think this is just avoiding the underlying ...
10 years, 6 months ago (2010-06-17 03:15:34 UTC) #3
Lei Zhang
On 2010/06/17 03:15:34, Patrick Horn wrote: > > I definitely agree with you that this ...
10 years, 6 months ago (2010-06-17 06:31:23 UTC) #4
Patrick Horn
Re-uploaded the test without the change to the existing arguments. I left the new parameter ...
10 years, 6 months ago (2010-06-17 16:59:01 UTC) #5
Lei Zhang
LGTM if you file a bug for the twenty tabs launch problem. http://codereview.chromium.org/2809017/diff/10001/11001 File chrome/test/startup/shutdown_test.cc ...
10 years, 6 months ago (2010-06-17 20:13:53 UTC) #6
Patrick Horn
Oh I think I forgot to mention the bug I filed is at http://crbug.com/46609 Is ...
10 years, 6 months ago (2010-06-17 23:05:46 UTC) #7
Lei Zhang
10 years, 6 months ago (2010-06-17 23:09:24 UTC) #8
LGTM

http://codereview.chromium.org/2809017/diff/15001/16001
File chrome/test/startup/shutdown_test.cc (right):

http://codereview.chromium.org/2809017/diff/15001/16001#newcode33
chrome/test/startup/shutdown_test.cc:33: SIMPLE, // Runs with no command line
arguments (loads about:blank).
code linter says "At least two spaces is best between code and comments"

Powered by Google App Engine
This is Rietveld 408576698