Issue 2809012: Change hash computation for transcendental cache to use arithmetic...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2809012: Change hash computation for transcendental cache to use arithmetic... (Closed)

Created:
10 years, 6 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Change hash computation for transcendental cache to use arithmetic shifts. Leads to fewer collisions. Committed: http://code.google.com/p/v8/source/detail?r=4872

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Erik Corry

10 years, 6 months ago (2010-06-16 08:28:29 UTC) #2

LGTM (now that Lasse has convinced me on the whiteboard that the 32 bit and 64
bit algorithms are still the same).