Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: chrome/browser/resources/options/chromeos_language_add_language_overlay.js

Issue 2808106: Show native language names in the add language overlay. (Closed)
Patch Set: minor change Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /////////////////////////////////////////////////////////////////////////////// 5 ///////////////////////////////////////////////////////////////////////////////
6 // AddLanguageOverlay class: 6 // AddLanguageOverlay class:
7 7
8 cr.define('options.language', function() { 8 cr.define('options.language', function() {
9 9
10 const OptionsPage = options.OptionsPage; 10 const OptionsPage = options.OptionsPage;
(...skipping 29 matching lines...) Expand all
40 40
41 // Create the language list with which users can add a language. 41 // Create the language list with which users can add a language.
42 // Note that we have about 40 languages. 42 // Note that we have about 40 languages.
43 var addLanguageList = $('add-language-overlay-language-list'); 43 var addLanguageList = $('add-language-overlay-language-list');
44 var languageListData = templateData.languageList; 44 var languageListData = templateData.languageList;
45 for (var i = 0; i < languageListData.length; i++) { 45 for (var i = 0; i < languageListData.length; i++) {
46 var language = languageListData[i]; 46 var language = languageListData[i];
47 var button = document.createElement('button'); 47 var button = document.createElement('button');
48 button.className = 'link-button'; 48 button.className = 'link-button';
49 button.textContent = language.displayName; 49 button.textContent = language.displayName;
50 // If the native name is different, add it.
51 if (language.displayName != language.nativeDisplayName) {
52 button.textContent += ' - ' + language.nativeDisplayName;
53 }
50 button.languageCode = language.code; 54 button.languageCode = language.code;
51 // Listen to user clicks. 55 // Listen to user clicks.
52 button.addEventListener('click', 56 button.addEventListener('click',
53 cr.bind(this.handleLanguageClick_, this)); 57 cr.bind(this.handleLanguageClick_, this));
54 var li = document.createElement('li'); 58 var li = document.createElement('li');
55 li.languageCode = language.code; 59 li.languageCode = language.code;
56 li.appendChild(button); 60 li.appendChild(button);
57 addLanguageList.appendChild(li); 61 addLanguageList.appendChild(li);
58 } 62 }
59 }, 63 },
60 }; 64 };
61 65
62 return { 66 return {
63 AddLanguageOverlay: AddLanguageOverlay 67 AddLanguageOverlay: AddLanguageOverlay
64 }; 68 };
65 }); 69 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698