Issue 2808106: Show native language names in the add language overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808106: Show native language names in the add language overlay. (Closed)

Created:
10 years, 4 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, dhg, Paweł Hajdan Jr., arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Show native language names in the add language overlay. For instance, "Finnish - suomi". This is what we do in the C++ version options. TEST=manually; out/Release/unit_tests --gtest_filter='*InputMethodUtil*' BUG=chromium-os:4573 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55044

Patch Set 1 #

Patch Set 2 : minor change #

Total comments: 2

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -3 lines)			Patch
M	chrome/browser/chromeos/dom_ui/language_options_handler.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/dom_ui/language_options_handler.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.h	View		1 chunk	+8 lines, -1 line	2 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos_language_add_language_overlay.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

lgtm http://codereview.chromium.org/2808106/diff/2001/3004 File chrome/browser/chromeos/input_method/input_method_util.h (right): http://codereview.chromium.org/2808106/diff/2001/3004#newcode99 chrome/browser/chromeos/input_method/input_method_util.h:99: // Examples: "fi" => "French" French -> Finnish

10 years, 4 months ago (2010-08-05 08:52:36 UTC) #2

satorux1

10 years, 4 months ago (2010-08-05 08:54:29 UTC) #3

http://codereview.chromium.org/2808106/diff/2001/3004
File chrome/browser/chromeos/input_method/input_method_util.h (right):

http://codereview.chromium.org/2808106/diff/2001/3004#newcode99
chrome/browser/chromeos/input_method/input_method_util.h:99: // Examples: "fi"  
 => "French"
On 2010/08/05 08:52:36, Yusuke Sato wrote:
> French -> Finnish
> 

Done.

Expand Messages | Collapse Messages