Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2808066: Merge 53562 - The scrollability of a bookmark menu should be reconsidered whe... (Closed)

Created:
10 years, 5 months ago by mrossetti
Modified:
9 years, 7 months ago
Reviewers:
mrossetti
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 53562 - The scrollability of a bookmark menu should be reconsidered whenever there is a change in the scrollability. BUG=44014 TEST=Perform the steps as described in the bug report and verify that the scroll arrow disappears. Then try pasting a new bookmark into the same menu and verify that the scroll arrow appears. Review URL: http://codereview.chromium.org/3027021 TBR=mrossetti@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/cocoa/bookmark_bar_folder_controller.mm View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mrossetti
10 years, 5 months ago (2010-07-26 18:04:29 UTC) #1
mrossetti
10 years, 5 months ago (2010-07-26 19:36:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698