Issue 2808056: An experimental fix for Bug 49590....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808056: An experimental fix for Bug 49590.... (Closed)

Created:
10 years, 5 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
John Gregg

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

An experimental fix for Bug 49590. This change just releases the BalloonController objects used in the tests. (This change does not use autorelease since I'm not sure if we can call autorelease before initializing an NSObject.) BUG=49590 TEST=make the "Chromium Mac (valgrind)" bot greener. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53921

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/notifications/balloon_controller_unittest.mm	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Gregg

10 years, 5 months ago (2010-07-23 16:12:16 UTC) #3

On 2010/07/23 04:11:30, hbono wrote:
> ping?

Apologies for not seeing this review earlier.  LGTM

Expand Messages | Collapse Messages