Issue 2808048: Reapply r51760 and r51761 that were reverted in r51767.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808048: Reapply r51760 and r51761 that were reverted in r51767. (Closed)

Created:
10 years, 5 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Reapply r51760 and r51761 that were reverted in r51767. Add the fix for FileImpl() plus unit tests. TEST=more tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52005

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -304 lines)			Patch
M	gclient.py	View	1	12 chunks	+222 lines, -292 lines	0 comments	Download
M	gclient_utils.py	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/gclient_smoketest.py	View	1	5 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

M-A Ruel

You can just look at the difference between patchsets 1 and 2 since patchset 1 ...

10 years, 5 months ago (2010-07-08 18:12:45 UTC) #1

M-A Ruel

Damn, I had forgot to put a reviewer. :( Can you take a look, I'd ...

10 years, 5 months ago (2010-07-09 20:02:56 UTC) #2

LGTM