Issue 2808043: [PATCH 2/5] build_kernel_image: add verified boot support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808043: [PATCH 2/5] build_kernel_image: add verified boot support (Closed)

Created:
10 years, 5 months ago by Will Drewry

Modified:
6 years ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Visibility:
Public.

Description

[PATCH 2/5] build_kernel_image: add verified boot support Adds rootfs image hashing to the build. If it is hashed even if the default boot device is not dm-0, the baseline rootfs integrity information will be included (though device setup will fail in the logs during boot). TEST=manually ran without enabling vboot support. BUG=chromium-os:327

Patch Set 1 #

Patch Set 2 : make sure it is against the correct origin #

Patch Set 3 : old include path was wrong #

Total comments: 1

Patch Set 4 : fix space #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -82 lines)			Patch
	M	build_kernel_image.sh	View	1 2 3	3 chunks	+150 lines, -82 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 5 months ago (2010-07-02 18:51:40 UTC) #2

LGTM

http://codereview.chromium.org/2808043/diff/5001/6001
File build_kernel_image.sh (right):

http://codereview.chromium.org/2808043/diff/5001/6001#newcode53
build_kernel_image.sh:53: #Die on error
the space was fine...

Expand Messages | Collapse Messages