Issue 2807035: Adds a unit test for Serbian and Ukranian dictionaries....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2807035: Adds a unit test for Serbian and Ukranian dictionaries.... (Closed)

Created:
10 years, 5 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
djevrek, jungshik at Google, Evan Stade

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Adds unit tests for Serbian and Ukranian dictionaries. This change is unit tests for <http://codereview.chromium.org/2805065/show>;. BUG=43011, 40340 TEST=unit_test --gtest_filter=SpellCheckTest* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53909

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	chrome/common/spellcheck_common.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	chrome/renderer/spellchecker/spellcheck_unittest.cc	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

Sorry for missing this. LGTM Only sr_Cyrl (not sr_Latn) was added, right?

10 years, 5 months ago (2010-07-13 18:58:20 UTC) #3

Hironori Bono

On 2010/07/13 18:58:20, Jungshik Shin wrote: > Only sr_Cyrl (not sr_Latn) was added, right? Yes. ...

10 years, 5 months ago (2010-07-14 03:08:38 UTC) #4

djevrek

So, when we will be able to use this Serbian dict in Chrome ? I'm ...

10 years, 5 months ago (2010-07-18 15:46:35 UTC) #5

Hironori Bono

10 years, 5 months ago (2010-07-19 07:56:52 UTC) #6

djevrek,

Thank you for your feedback.
Currently, we are uploading these dictionaries to the dictionary-download server
so Chrome can automatically download them from the server. When Chrome (and
Chromium) is ready to use Serbian and Ukranian dictionaries, I will update Issue
43011 and Issue 40340 to announce it.

Regards,

Hironori Bono

Expand Messages | Collapse Messages