Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 2807033: Add support for omnibox.onInputStarted and onInputCancelled. (Closed)
Patch Set: fix Stop Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/notification_type.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extension_process_bindings.js
diff --git a/chrome/renderer/resources/extension_process_bindings.js b/chrome/renderer/resources/extension_process_bindings.js
index c408f8e544c405854947063c3066190668aeed3b..4a59dcb78694afecfefb58774dd69a6ae315bc12 100644
--- a/chrome/renderer/resources/extension_process_bindings.js
+++ b/chrome/renderer/resources/extension_process_bindings.js
@@ -246,18 +246,6 @@ var chrome = chrome || {};
// Setup events for each extension_id/page_action_id string we find.
chrome.pageActions[pageActions[i]] = new chrome.Event(oldStyleEventName);
}
-
- // Note this is singular.
- var eventName = "pageAction/" + extensionId;
- chrome.pageAction = chrome.pageAction || {};
- chrome.pageAction.onClicked = new chrome.Event(eventName);
- }
-
- // Browser action events send {windowpId}.
- function setupBrowserActionEvent(extensionId) {
- var eventName = "browserAction/" + extensionId;
- chrome.browserAction = chrome.browserAction || {};
- chrome.browserAction.onClicked = new chrome.Event(eventName);
}
function setupToolstripEvents(renderViewId) {
@@ -294,11 +282,6 @@ var chrome = chrome || {};
}
function setupOmniboxEvents(extensionId) {
- chrome.experimental.omnibox.onInputEntered =
- new chrome.Event("experimental.omnibox.onInputEntered/" + extensionId);
-
- chrome.experimental.omnibox.onInputChanged =
- new chrome.Event("experimental.omnibox.onInputChanged/" + extensionId);
chrome.experimental.omnibox.onInputChanged.dispatch =
function(text, requestId) {
var suggestCallback = function(suggestions) {
@@ -394,6 +377,8 @@ var chrome = chrome || {};
return;
var eventName = apiDef.namespace + "." + eventDef.name;
+ if (eventDef.perExtensionEvent)
+ eventName = eventName + "/" + extensionId;
module[eventDef.name] = new chrome.Event(eventName,
eventDef.parameters);
});
@@ -671,7 +656,6 @@ var chrome = chrome || {};
chrome.test.getApiDefinitions = GetExtensionAPIDefinition;
}
- setupBrowserActionEvent(extensionId);
setupPageActionEvents(extensionId);
setupToolstripEvents(GetRenderViewId());
setupPopupEvents(GetRenderViewId());
« no previous file with comments | « chrome/common/notification_type.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698