Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2807030: Remove a known crash in HTML5DocumentParser::write() which has been fixed... (Closed)

Created:
10 years, 5 months ago by tonyg
Modified:
9 years, 6 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove a known crash in HTML5DocumentParser::write() which has been fixed upstream. This is guaranteed to work as the HTML5DocumentParser class has since been renamed to HTMLDocumentParser. BUG=47080 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/test/data/reliability/known_crashes.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
10 years, 5 months ago (2010-06-29 18:20:50 UTC) #1
abarth-chromium
10 years, 5 months ago (2010-06-29 18:43:04 UTC) #2
LGTM

On Tue, Jun 29, 2010 at 11:20 AM,  <tonyg@chromium.org> wrote:
> Reviewers: abarth,
>
> Description:
> Remove a known crash in HTML5DocumentParser::write() which has been fixed
> upstream. This is guaranteed to work as the HTML5DocumentParser class has
> since
> been renamed to HTMLDocumentParser.
>
> BUG=47080
> TEST=None
>
> Please review this at http://codereview.chromium.org/2807030/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/test/data/reliability/known_crashes.txt
>
>
> Index: chrome/test/data/reliability/known_crashes.txt
> ===================================================================
> --- chrome/test/data/reliability/known_crashes.txt      (revision 51134)
> +++ chrome/test/data/reliability/known_crashes.txt      (working copy)
> @@ -174,10 +174,6 @@
>  # 46106
>  PREFIX:
>
webcore::reportfatalerrorinv8___v8::internal::v8::fatalprocessoutofmemory___v8::internal::setelement___v8::internal::runtime::setobjectproperty___v8::internal::runtime_setproperty___v8::internal::invoke___v8::internal::execution::call___v8::script::run___webcore::v8proxy::runscript___webcore::v8proxy::evaluate___webcore::scriptcontroller::evaluate___webcore::scriptcontroller::executescript___webcore::htmltokenizer::scriptexecution
>
> -# 47080
> -PREFIX:
>
-webcore::html5documentparser::write___webcore::document::write___webcore::document::write___webcore::v8htmldocument::writecallback___v8::internal::handleapicallhelper<0>___v8::internal::builtin_handleapicall___v8::internal::invoke___v8::internal::execution::call___v8::script::run___webcore::v8proxy::runscript___webcore::v8proxy::evaluate___webcore::scriptcontroller::evaluate___webcore::scriptcontroller::executescript___webcore::html5documentparser::executescript___webcore::html5scriptrunner::runscript
> -
>  # 47207
>
 messageloop::runtask___messageloop::deferorrunpendingtask___messageloop::dodelayedwork___base::messagepumpforio::dorunloop___base::messagepumpwin::run___messageloop::runinternal___messageloop::run___base::thread::run___base::thread::threadmain___`anonymous
> namespace'::threadfunc
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698