Issue 2807029: Move GetPageSizeAndMarginsInPoints from linux code to generic code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2807029: Move GetPageSizeAndMarginsInPoints from linux code to generic code. (Closed)

Created:
10 years, 5 months ago by hamaji

Modified:
9 years, 5 months ago

Reviewers:
hayato, Yuzo

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Move GetPageSizeAndMarginsInPoints from linux code to generic code. It seems we can use this function in other environments. BUG=47277 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51227

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/params/default_params/ #

Created: 10 years, 5 months ago

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -66 lines)
M	chrome/renderer/print_web_view_helper.h	View	1 chunk	+11 lines, -0 lines	0 comments
M	chrome/renderer/print_web_view_helper.cc	View	2 chunks	+85 lines, -0 lines	0 comments
M	chrome/renderer/print_web_view_helper_linux.cc	View	5 chunks	+30 lines, -66 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yuzo

LGTM http://codereview.chromium.org/2807029/diff/1/3 File chrome/renderer/print_web_view_helper.h (right): http://codereview.chromium.org/2807029/diff/1/3#newcode130 chrome/renderer/print_web_view_helper.h:130: const ViewMsg_Print_Params& params, Perhaps default_params is a better ...

10 years, 5 months ago (2010-06-30 01:07:50 UTC) #2

hamaji

10 years, 5 months ago (2010-06-30 04:46:42 UTC) #3

Thanks for your review.

http://codereview.chromium.org/2807029/diff/1/3
File chrome/renderer/print_web_view_helper.h (right):

http://codereview.chromium.org/2807029/diff/1/3#newcode130
chrome/renderer/print_web_view_helper.h:130: const ViewMsg_Print_Params& params,
On 2010/06/30 01:07:50, Yuzo wrote:
> Perhaps default_params is a better name?

Done.

Expand Messages | Collapse Messages