Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2807028: image_to_usb.sh needs to pass --board to mod_image_for_test (Closed)

Created:
10 years, 5 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

image_to_usb.sh needs to pass --board to mod_image_for_test At some point, mod_image_for_test started using emerge, but when we call it from image_to_usb, we don't pass a --board flag...we just assume the user is using the default_board magic file mechanism.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M image_to_usb.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
10 years, 5 months ago (2010-06-29 01:15:53 UTC) #1
sosa
10 years, 5 months ago (2010-06-29 02:26:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698