Added support for vector printing for Pepper v1 plugins for Linux....

Added support for vector printing for Pepper v1 plugins for Linux.
BUG=None
TEST=Test printing from Chrome PDF plugin on Linux.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51181

[James Hawkins, 2010-06-29 17:13:45]

http://codereview.chromium.org/2807027/diff/1/2
File chrome/renderer/webplugin_delegate_pepper.cc (right):

http://codereview.chromium.org/2807027/diff/1/2#newcode1136
chrome/renderer/webplugin_delegate_pepper.cc:1136: num_pages_ = num_pages;
So it looks like |num_pages| is int32 per the API. Maybe we should store it as
int32 as well (re: my previous comment about size_t).

http://codereview.chromium.org/2807027/diff/1/3
File chrome/renderer/webplugin_delegate_pepper.h (right):

http://codereview.chromium.org/2807027/diff/1/3#newcode300
chrome/renderer/webplugin_delegate_pepper.h:300: // to keep the pixels valis
until CGContextEndPage is called. We use this
While you're here, s/valis/valid/

http://codereview.chromium.org/2807027/diff/1/3#newcode311
chrome/renderer/webplugin_delegate_pepper.h:311: int num_pages_;
This is a count. Should it be size_t?

http://codereview.chromium.org/2807027/diff/1/4
File printing/pdf_ps_metafile_cairo.cc (right):

http://codereview.chromium.org/2807027/diff/1/4#newcode22
printing/pdf_ps_metafile_cairo.cc:22: static const cairo_user_data_key_t
kPdfMetafileKey = {0};
No need for static in unnamed namespace.

http://codereview.chromium.org/2807027/diff/1/4#newcode65
printing/pdf_ps_metafile_cairo.cc:65: void DestroyContextData(void * data) {
void*

[sanjeevr, 2010-06-29 17:32:14]

Made the changes.

http://codereview.chromium.org/2807027/diff/1/2
File chrome/renderer/webplugin_delegate_pepper.cc (right):

http://codereview.chromium.org/2807027/diff/1/2#newcode1136
chrome/renderer/webplugin_delegate_pepper.cc:1136: num_pages_ = num_pages;
On 2010/06/29 17:13:45, James Hawkins wrote:
> So it looks like |num_pages| is int32 per the API. Maybe we should store it as
> int32 as well (re: my previous comment about size_t).

Done.

http://codereview.chromium.org/2807027/diff/1/3
File chrome/renderer/webplugin_delegate_pepper.h (right):

http://codereview.chromium.org/2807027/diff/1/3#newcode300
chrome/renderer/webplugin_delegate_pepper.h:300: // to keep the pixels valis
until CGContextEndPage is called. We use this
On 2010/06/29 17:13:45, James Hawkins wrote:
> While you're here, s/valis/valid/

Done.

http://codereview.chromium.org/2807027/diff/1/3#newcode311
chrome/renderer/webplugin_delegate_pepper.h:311: int num_pages_;
Made this an int32
On 2010/06/29 17:13:45, James Hawkins wrote:
> This is a count. Should it be size_t?

http://codereview.chromium.org/2807027/diff/1/4
File printing/pdf_ps_metafile_cairo.cc (right):

http://codereview.chromium.org/2807027/diff/1/4#newcode22
printing/pdf_ps_metafile_cairo.cc:22: static const cairo_user_data_key_t
kPdfMetafileKey = {0};
On 2010/06/29 17:13:45, James Hawkins wrote:
> No need for static in unnamed namespace.

Done.

http://codereview.chromium.org/2807027/diff/1/4#newcode65
printing/pdf_ps_metafile_cairo.cc:65: void DestroyContextData(void * data) {
On 2010/06/29 17:13:45, James Hawkins wrote:
> void*

Done.

[James Hawkins, 2010-06-29 17:36:47]

LGTM