Make pinned tabs a little stickier.

Make pinned tabs a little stickier.

Use the same algorithm for rewriting the window open disposition as we use for link clicking.

BUG=47190
TEST=manual; unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50674

[sky, 2010-06-23 17:31:15]

http://codereview.chromium.org/2807016/diff/1/2
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2807016/diff/1/2#newcode1236
chrome/browser/browser.cc:1236: selected_contents->GetURL(),
handle null selected_contents?

http://codereview.chromium.org/2807016/diff/1/2#newcode3641
chrome/browser/browser.cc:3641: transition != PageTransition::LINK &&
can you indent this and the next line one characterto make it clear it's part of
the ( on 2640.

[Peter Kasting, 2010-06-23 18:28:20]

LGTM with sky's nits addressed.

[Evan Stade, 2010-06-23 20:36:07]

http://codereview.chromium.org/2807016/diff/1/2
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2807016/diff/1/2#newcode1236
chrome/browser/browser.cc:1236: selected_contents->GetURL(),
On 2010/06/23 17:31:15, sky wrote:
> handle null selected_contents?

Done.

http://codereview.chromium.org/2807016/diff/1/2#newcode3641
chrome/browser/browser.cc:3641: transition != PageTransition::LINK &&
On 2010/06/23 17:31:15, sky wrote:
> can you indent this and the next line one characterto make it clear it's part
of
> the ( on 2640.

Done.

[sky, 2010-06-23 20:46:38]

LGTM