Update screen refactoring, exit on successful update.

Update screen refactoring, exit on successful update.

BUG= http://crosbug.com/4002
TEST=Manual: execute OOBE, make sure that update is available, wait for update to complete. If update_engine returns successful update code OOBE will proceed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51509

[Nikita (slow), 2010-06-22 12:06:13]

I'll check about phrasing on update screen and submit grd change CL before this
one.

[Nikita (slow), 2010-06-22 12:48:26]

In case we'll reboot using API I'll submit this CL with refactoring only.

[dr, 2010-06-22 13:43:48]

http://codereview.chromium.org/2807013/diff/2001/3001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2807013/diff/2001/3001#newcode7528
chrome/app/generated_resources.grd:7528: <ph name="PRODUCT_NAME">$1<ex>Chrome
OS</ex></ph> has successfully installed an important update.\nPlease restart
your computer by switching power button off and then on again.
Maybe "Chrome OS was successfully updated.\nPlease restart your computer by
switching power button off and then on again."?

http://codereview.chromium.org/2807013/diff/2001/3002
File chrome/browser/chromeos/login/update_screen.cc (right):

http://codereview.chromium.org/2807013/diff/2001/3002#newcode60
chrome/browser/chromeos/login/update_screen.cc:60: RequireManualReboot();
Let's just put this method's body here.

[Nikita (slow), 2010-06-22 14:05:49]

http://codereview.chromium.org/2807013/diff/2001/3001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2807013/diff/2001/3001#newcode7528
chrome/app/generated_resources.grd:7528: <ph name="PRODUCT_NAME">$1<ex>Chrome
OS</ex></ph> has successfully installed an important update.\nPlease restart
your computer by switching power button off and then on again.
On 2010/06/22 13:43:49, dr wrote:
> Maybe "Chrome OS was successfully updated.\nPlease restart your computer by
> switching power button off and then on again."?

Done.

http://codereview.chromium.org/2807013/diff/2001/3002
File chrome/browser/chromeos/login/update_screen.cc (right):

http://codereview.chromium.org/2807013/diff/2001/3002#newcode60
chrome/browser/chromeos/login/update_screen.cc:60: RequireManualReboot();
On 2010/06/22 13:43:49, dr wrote:
> Let's just put this method's body here.

Done.

[dr, 2010-06-22 15:11:20]

LGTM

fix typo

http://codereview.chromium.org/2807013/diff/7001/8001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2807013/diff/7001/8001#newcode7525
chrome/app/generated_resources.grd:7525: <ph name="PRODUCT_NAME">$1<ex>Chrome
OS</ex></ph> has ben successfully updated.\nPlease restart your computer by
switching power button off and then on again.
has beEn

[Nikita (slow), 2010-06-22 15:19:05]

http://codereview.chromium.org/2807013/diff/7001/8001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/2807013/diff/7001/8001#newcode7525
chrome/app/generated_resources.grd:7525: <ph name="PRODUCT_NAME">$1<ex>Chrome
OS</ex></ph> has ben successfully updated.\nPlease restart your computer by
switching power button off and then on again.
On 2010/06/22 15:11:20, dr wrote:
> has beEn

Done.