Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 28069: A refinement of cl 28068. (Closed)

Created:
11 years, 10 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

A refinement of cl 28068.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 10 months ago (2009-02-24 14:54:46 UTC) #1
Søren Thygesen Gjesse
LGTM
11 years, 10 months ago (2009-02-24 14:56:03 UTC) #2
Mikhail Naganov
11 years, 10 months ago (2009-02-24 14:56:34 UTC) #3
I'm not sure that it's worth dealing with external resources in test because
StringMatch only branches on ASCII vs. UC16 strings (in a single char pattern
case).

Powered by Google App Engine
This is Rietveld 408576698