Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: test/cctest/test-compiler.cc

Issue 28068: Fixed regression http://code.google.com/p/v8/issues/detail?id=236. (Closed)
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 *Factory::LookupAsciiSymbol("foo"))); 295 *Factory::LookupAsciiSymbol("foo")));
296 CHECK(fun1->IsJSFunction()); 296 CHECK(fun1->IsJSFunction());
297 297
298 Object** argv[1] = { 298 Object** argv[1] = {
299 Handle<Object>::cast(Factory::LookupAsciiSymbol("hello")).location() 299 Handle<Object>::cast(Factory::LookupAsciiSymbol("hello")).location()
300 }; 300 };
301 Execution::Call(Handle<JSFunction>::cast(fun1), global, 1, argv, 301 Execution::Call(Handle<JSFunction>::cast(fun1), global, 1, argv,
302 &has_pending_exception); 302 &has_pending_exception);
303 CHECK(!has_pending_exception); 303 CHECK(!has_pending_exception);
304 } 304 }
305
306
307 // Regression 236. Calling InitLineEnds on a Script with undefined
308 // source resulted in crash.
309 TEST(Regression236) {
310 InitializeVM();
311 v8::HandleScope scope;
312
313 Handle<Script> script = Factory::NewScript(Factory::empty_string());
314 script->set_source(Heap::undefined_value());
315 CHECK_EQ(-1, script->GetLineNumber(0));
316 CHECK_EQ(-1, script->GetLineNumber(100));
317 CHECK_EQ(-1, script->GetLineNumber(-1));
Søren Thygesen Gjesse 2009/02/24 13:23:52 As this bug originated from Chrome where source is
Mikhail Naganov 2009/02/24 13:41:01 Ok, will add such test. But it will be a new CL si
318 }
OLDNEW
« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698