Issue 2806081: DOMUI prefs: Add stub sub-page for search engine management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2806081: DOMUI prefs: Add stub sub-page for search engine management (Closed)

Created:
10 years, 5 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), zel

CC:
chromium-reviews, dhg, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

Description

DOMUI prefs: Add stub sub-page for search engine management BUG=49091 TEST='Manage' button in DOMUI Basics prefs should bring up an empty sub-page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53807

Patch Set 1 #

Patch Set 2 : Rebased to trunk #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -8 lines)			Patch
M	chrome/browser/dom_ui/options_ui.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/dom_ui/search_engine_manager_handler.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	chrome/browser/dom_ui/search_engine_manager_handler.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options.html	View	1	3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/options/browser_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/resources/options/search_engine_manager.html	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/options/search_engine_manager.js	View		1 chunk	+29 lines, -0 lines	1 comment	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years, 5 months ago (2010-07-27 18:58:36 UTC) #3

LGTM

http://codereview.chromium.org/2806081/diff/11/3008
File chrome/browser/resources/options/search_engine_manager.js (right):

http://codereview.chromium.org/2806081/diff/11/3008#newcode13
chrome/browser/resources/options/search_engine_manager.js:13: this.activeNavTab
= null;
this line seems unnecessary

Expand Messages | Collapse Messages