Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x64/disasm-x64.cc

Issue 2806080: X64: Fix order of operands on movq(reg, xmm). (Closed)
Patch Set: Also fixed disassembler. Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1001 matching lines...) Expand 10 before | Expand all | Expand 10 after
1012 UnimplementedInstruction(); 1012 UnimplementedInstruction();
1013 } 1013 }
1014 } else { 1014 } else {
1015 get_modrm(*current, &mod, &regop, &rm); 1015 get_modrm(*current, &mod, &regop, &rm);
1016 if (opcode == 0x6E) { 1016 if (opcode == 0x6E) {
1017 AppendToBuffer("mov%c %s,", 1017 AppendToBuffer("mov%c %s,",
1018 rex_w() ? 'q' : 'd', 1018 rex_w() ? 'q' : 'd',
1019 NameOfXMMRegister(regop)); 1019 NameOfXMMRegister(regop));
1020 current += PrintRightOperand(current); 1020 current += PrintRightOperand(current);
1021 } else if (opcode == 0x7E) { 1021 } else if (opcode == 0x7E) {
1022 AppendToBuffer("mov%c %s,", 1022 AppendToBuffer("mov%c ",
1023 rex_w() ? 'q' : 'd', 1023 rex_w() ? 'q' : 'd');
1024 NameOfCPURegister(regop)); 1024 current += PrintRightOperand(current);
1025 current += PrintRightXMMOperand(current); 1025 AppendToBuffer(", %s", NameOfXMMRegister(regop));
1026 } else { 1026 } else {
1027 const char* mnemonic = "?"; 1027 const char* mnemonic = "?";
1028 if (opcode == 0x57) { 1028 if (opcode == 0x57) {
1029 mnemonic = "xorpd"; 1029 mnemonic = "xorpd";
1030 } else if (opcode == 0x2E) { 1030 } else if (opcode == 0x2E) {
1031 mnemonic = "ucomisd"; 1031 mnemonic = "ucomisd";
1032 } else if (opcode == 0x2F) { 1032 } else if (opcode == 0x2F) {
1033 mnemonic = "comisd"; 1033 mnemonic = "comisd";
1034 } else { 1034 } else {
1035 UnimplementedInstruction(); 1035 UnimplementedInstruction();
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
1687 for (int i = 6 - static_cast<int>(pc - prev_pc); i >= 0; i--) { 1687 for (int i = 6 - static_cast<int>(pc - prev_pc); i >= 0; i--) {
1688 fprintf(f, " "); 1688 fprintf(f, " ");
1689 } 1689 }
1690 fprintf(f, " %s\n", buffer.start()); 1690 fprintf(f, " %s\n", buffer.start());
1691 } 1691 }
1692 } 1692 }
1693 1693
1694 } // namespace disasm 1694 } // namespace disasm
1695 1695
1696 #endif // V8_TARGET_ARCH_X64 1696 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698