Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2806080: X64: Fix order of operands on movq(reg, xmm). (Closed)

Created:
10 years, 5 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64: Fix order of operands on movq(reg, xmm). Fixes bug 792, and the Transcendental cache is the only use of this operation.

Patch Set 1 #

Patch Set 2 : Also fixed disassembler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein
10 years, 5 months ago (2010-07-27 11:32:16 UTC) #1
William Hesse
Looks great to me!
10 years, 5 months ago (2010-07-27 11:34:54 UTC) #2
Vladislav Kaznacheev
Drive-by comment: should not the disassembler change as well?
10 years, 5 months ago (2010-07-27 11:42:53 UTC) #3
Lasse Reichstein
Good catch. Yes, the disassembler is also broken.
10 years, 5 months ago (2010-07-27 11:55:32 UTC) #4
William Hesse
10 years, 5 months ago (2010-07-27 12:01:42 UTC) #5 
Looks even better to me now.

Powered by Google App Engine
This is Rietveld 408576698