Stream to file implementation.

Initial stream to file implementation.

This patch excludes one important detail.  This code does not cleanup temp
files yet.  That will be added in a subsequent CL.

R=brettw
BUG=49789
TEST=third_party/ppapi/tests/test_url_loader.cc:TestStreamToFile


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53923

[brettw, 2010-07-27 21:52:45]

http://codereview.chromium.org/2806079/diff/14002/8004
File chrome/browser/renderer_host/redirect_to_file_resource_handler.cc (right):

http://codereview.chromium.org/2806079/diff/14002/8004#newcode52
chrome/browser/renderer_host/redirect_to_file_resource_handler.cc:52:
file_util::CreateTemporaryFile(&file_path_);  // XXX file i/o?
What did you mean to do with this?

http://codereview.chromium.org/2806079/diff/14002/8004#newcode105
chrome/browser/renderer_host/redirect_to_file_resource_handler.cc:105: int rv =
file_stream_.Open(file_path_, base::PLATFORM_FILE_OPEN |
Is this also I/O on the I/O thread?

http://codereview.chromium.org/2806079/diff/14002/8005
File chrome/browser/renderer_host/redirect_to_file_resource_handler.h (right):

http://codereview.chromium.org/2806079/diff/14002/8005#newcode44
chrome/browser/renderer_host/redirect_to_file_resource_handler.h:44:
~RedirectToFileResourceHandler();
Blank line after this. I also usually type "virtual" when inheriting from a
virtual base class (just to make this more clear).

http://codereview.chromium.org/2806079/diff/14002/8005#newcode54
chrome/browser/renderer_host/redirect_to_file_resource_handler.h:54:
scoped_refptr<net::GrowableIOBuffer> buf_;
Can you comment these? Maybe a comment for this block of 3 explaining how
buffering works would be sufficient.

http://codereview.chromium.org/2806079/diff/14002/8005#newcode60
chrome/browser/renderer_host/redirect_to_file_resource_handler.h:60:
net::CompletionCallbackImpl<RedirectToFileResourceHandler> write_callback_;
Ditto for writing.

[darin (slow to review), 2010-07-28 00:00:23]

On Tue, Jul 27, 2010 at 2:52 PM, <brettw@chromium.org> wrote:

>
> http://codereview.chromium.org/2806079/diff/14002/8004
> File chrome/browser/renderer_host/redirect_to_file_resource_handler.cc
> (right):
>
> http://codereview.chromium.org/2806079/diff/14002/8004#newcode52
> chrome/browser/renderer_host/redirect_to_file_resource_handler.cc:52:
> file_util::CreateTemporaryFile(&file_path_);  // XXX file i/o?
> What did you mean to do with this?
>

sorry, i didn't post the newer CL that has a TODO comment.  i basically need
to
figure out if i should care about the synchronous file create and open
calls.

i'd like to fix that as a follow-up so that i can get this API in place to
unblock
the nacl plugin.  i'll be filing bugs that block enabling this code for
realz.



>
> http://codereview.chromium.org/2806079/diff/14002/8004#newcode105
> chrome/browser/renderer_host/redirect_to_file_resource_handler.cc:105:
> int rv = file_stream_.Open(file_path_, base::PLATFORM_FILE_OPEN |
> Is this also I/O on the I/O thread?
>
> http://codereview.chromium.org/2806079/diff/14002/8005
> File chrome/browser/renderer_host/redirect_to_file_resource_handler.h
> (right):
>
> http://codereview.chromium.org/2806079/diff/14002/8005#newcode44
> chrome/browser/renderer_host/redirect_to_file_resource_handler.h:44:
> ~RedirectToFileResourceHandler();
> Blank line after this. I also usually type "virtual" when inheriting
> from a virtual base class (just to make this more clear).
>

OK


>
> http://codereview.chromium.org/2806079/diff/14002/8005#newcode54
> chrome/browser/renderer_host/redirect_to_file_resource_handler.h:54:
> scoped_refptr<net::GrowableIOBuffer> buf_;
> Can you comment these? Maybe a comment for this block of 3 explaining
> how buffering works would be sufficient.
>

OK


>
> http://codereview.chromium.org/2806079/diff/14002/8005#newcode60
> chrome/browser/renderer_host/redirect_to_file_resource_handler.h:60:
> net::CompletionCallbackImpl<RedirectToFileResourceHandler>
> write_callback_;
> Ditto for writing.
>
>
> http://codereview.chromium.org/2806079/show
>

[brettw, 2010-07-28 00:02:25]

LGTM