Issue 2806077: Support chromeos::RemapModifierKeys API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2806077: Support chromeos::RemapModifierKeys API. (Closed)

Created:
10 years, 5 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, Zachary Kuznia, kochi

Visibility:
Public.

Support chromeos::RemapModifierKeys API. BUG=chromium-os:2636 TEST=manually on eeepc, ran the browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53752

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -0 lines)			Patch
M	chrome/browser/chromeos/cros/cros_in_process_browser_test.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/keyboard_library.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/keyboard_library.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mock_keyboard_library.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

satorux1

10 years, 5 months ago (2010-07-26 08:09:15 UTC) #2

LGTM

Please also note that you ran tests properly in the BUG= line.

On 2010/07/26 07:52:34, Yusuke Sato wrote:
>