Issue 2806070: cros: fix more of the third_party includes, forbid similar includes for futur...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2806070: cros: fix more of the third_party includes, forbid similar includes for futur... (Closed)

Created:
10 years, 5 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore, zel

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

cros: fix more of the third_party includes, forbid similar includes for future

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -5 lines)			Patch
M	chrome/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/frame/panel_browser_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/frame/panel_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/notifications/notification_panel.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

zbehan

10 years, 5 months ago (2010-07-23 04:23:01 UTC) #1

This doesn't pass trybot, however, I have no idea how this CL could cause that.
It's unresolved externals.

http://build.chromium.org/buildbot/try-server/builders/win/builds/41444/steps...

I believe the breakage might be caused by something else being weird.

Expand Messages | Collapse Messages