DescriptionMac: Add nice fade effect to overflowing bookmark buttons in the bookmark bar
Port magic from GTMFadeTruncatingTextFieldCell to Chrome's GradientButtonCell, used by buttons in the bookmark bar. Any button that inherits from this class will now get overflowing titles truncated with a nice gradient (same as tab titles), rather than the default ellipsis.
Using GTMFadeTruncatingTextFieldCell in this case wasn't feasible because bookmark buttons are subclasses of NSButtonCell and already use a bunch of specialized behavior provided by it.
BUG=45104
TEST=Add a bookmark to the bookmark bar and increase the length of it's title. Once you get past a certain length, rather than truncate the title should fade out nicely. Exactly in the same way long tab titles do. Bookmark buttons with titles that aren't truncated should look exactly the same. Also test with Dolce & Gabbana theme which has inverted contrast.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53773
Patch Set 1 #Patch Set 2 : remove extra nl #
Total comments: 1
Messages
Total messages: 2 (0 generated)
|