Issue 2806049: Allow Pepper plugins to make requests with relative urls.

Issue 2806049: Allow Pepper plugins to make requests with relative urls. (Closed)

Created:
10 years, 5 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review), brettw

CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow Pepper plugins to make requests with relative urls. Also allow bundled Pepper plugins to specify file extensions. BUG=48140 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51542

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
M	chrome/browser/plugin_service.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/common/pepper_plugin_registry.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/pepper_plugin_registry.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_url_loader.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_url_request_info.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_url_request_info.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM http://codereview.chromium.org/2806049/diff/1/5 File webkit/glue/plugins/pepper_url_loader.cc (right): http://codereview.chromium.org/2806049/diff/1/5#newcode179 webkit/glue/plugins/pepper_url_loader.cc:179: frame->document().completeURL(UTF8ToUTF16(request->url()))); nit: please use WebString::fromUTF8() instead of UTF8ToUTF16 ...

10 years, 5 months ago (2010-07-02 16:24:00 UTC) #2

jam

http://codereview.chromium.org/2806049/diff/1/5 File webkit/glue/plugins/pepper_url_loader.cc (right): http://codereview.chromium.org/2806049/diff/1/5#newcode179 webkit/glue/plugins/pepper_url_loader.cc:179: frame->document().completeURL(UTF8ToUTF16(request->url()))); On 2010/07/02 16:24:01, darin wrote: > nit: please ...

10 years, 5 months ago (2010-07-02 16:52:40 UTC) #3

darin (slow to review)

10 years, 5 months ago (2010-07-02 16:54:25 UTC) #5

On Fri, Jul 2, 2010 at 9:52 AM, <jam@chromium.org> wrote:

>
> http://codereview.chromium.org/2806049/diff/1/5
> File webkit/glue/plugins/pepper_url_loader.cc (right):
>
> http://codereview.chromium.org/2806049/diff/1/5#newcode179
> webkit/glue/plugins/pepper_url_loader.cc:179:
> frame->document().completeURL(UTF8ToUTF16(request->url())));
> On 2010/07/02 16:24:01, darin wrote:
>
>> nit: please use WebString::fromUTF8() instead of UTF8ToUTF16 as it
>>
> avoids one
>
>> copy.
>>
>
> Done.
>
>
> http://codereview.chromium.org/2806049/diff/1/6
> File webkit/glue/plugins/pepper_url_request_info.cc (right):
>
> http://codereview.chromium.org/2806049/diff/1/6#newcode121
> webkit/glue/plugins/pepper_url_request_info.cc:121: // Keep the url in a
> string instead of a URL object because it might not
> On 2010/07/02 16:24:01, darin wrote:
>
>> I'm wondering if we shouldn't just do this for all properties...
>>
>
> I thought about it, but I didn't know how
> AppendDataToBody/AppendFileToBody were going to be implemented (i.e. by
> writing to the web_request_) so I left as is.


Yeah...


>
>
> http://codereview.chromium.org/2806049/show
>

Expand Messages | Collapse Messages