Issue 2806043: Add crash reporting to metrics_daemon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2806043: Add crash reporting to metrics_daemon. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git/metrics.git

Visibility:
Public.

Description

Add crash reporting to metrics_daemon. BUG=none TEST=unit tests,gmerge'd on device, verified it runs OK, pkill -SEGV generated minidump.

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Makefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

10 years, 5 months ago (2010-06-29 20:01:51 UTC) #2

LGTM

On Tue, Jun 29, 2010 at 12:27 PM,  <petkov@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Add crash reporting to metrics_daemon.
>
> BUG=none
> TEST=unit tests,gmerge'd on device, verified it runs OK, pkill -SEGV
> generated
> minidump.
>
> Please review this at http://codereview.chromium.org/2806043/show
>
> SVN Base: ssh://git@chromiumos-git/metrics.git
>
> Affected files:
>  M Makefile
>
>
> Index: Makefile
> diff --git a/Makefile b/Makefile
> index
>
298607876051d7c09e8811659a8b45561666b259..480da220ae6ff77b4e31bb819764807e96cdae00
> 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -53,7 +53,7 @@ $(COUNTER_TEST): $(TESTCOUNTER_OBJS)
>        $(CXX) -o $@ $^ $(TESTCOUNTER_LIBS)
>
>  $(DAEMON): $(DAEMON_OBJS) $(SHAREDLIB)
> -       $(CXX) -o $@ $^ $(DAEMON_LDFLAGS)
> +       $(CXX) -o $@ $^ $(DAEMON_LDFLAGS) -lcrash
>
>  $(DAEMON_TEST): $(TESTDAEMON_OBJS)
>        $(CXX) -o $@ $^ $(DAEMON_LDFLAGS) $(TESTDAEMON_LIBS)
>
>
>

Expand Messages | Collapse Messages