A simple script to check all control files for correctness.

A simple script to check all control files for correctness.

[ericli, 2010-06-18 00:32:49]

Otherwise, LGTM.

On Thu, Jun 17, 2010 at 5:26 PM, Eric Li(李咏竹) <ericli@chromium.org> wrote:

> Copyright 2010
>
>
> On Thu, Jun 17, 2010 at 5:20 PM, <kdlucas@chromium.org> wrote:
>
>> Reviewers: ericli,
>>
>> Description:
>> A simple script to check all control files for correctness.
>>
>> Please review this at http://codereview.chromium.org/2806016/show
>>
>> SVN Base: ssh://git@chromiumos-git//crosutils.git
>>
>> Affected files:
>>  A check_control_files.sh
>>
>>
>> Index: check_control_files.sh
>> diff --git a/check_control_files.sh b/check_control_files.sh
>> new file mode 100755
>> index
>>
0000000000000000000000000000000000000000..6f3364ad222bb45c33d12774c8f3d410d7e4b6cb
>> --- /dev/null
>> +++ b/check_control_files.sh
>> @@ -0,0 +1,15 @@
>> +#!/bin/bash
>> +
>> +# Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
>> +# Use of this source code is governed by a BSD-style license that can be
>> +# found in the LICENSE file.
>> +
>> +# This script will check all existing AutoTest control files for
>> correctness.
>> +
>> +. "$(dirname "$0")/common.sh"
>> +
>> +AUTOTEST_ROOT=${SRC_ROOT}/third_party/autotest/files
>> +CHECKSCRIPT=${AUTOTEST_ROOT}/utils/check_control_file_vars.py
>> +SITE_TESTS=${AUTOTEST_ROOT}/client/site_tests
>> +
>> +find $SITE_TESTS -maxdepth 2 -name control | xargs -n1 $CHECKSCRIPT
>>
>>
>>
>
>
> --
> Eric Li
> 李咏竹
> Google Kirkland
>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[ericli, 2010-06-18 00:33:54]

Copyright 2010

On Thu, Jun 17, 2010 at 5:20 PM, <kdlucas@chromium.org> wrote:

> Reviewers: ericli,
>
> Description:
> A simple script to check all control files for correctness.
>
> Please review this at http://codereview.chromium.org/2806016/show
>
> SVN Base: ssh://git@chromiumos-git//crosutils.git
>
> Affected files:
>  A check_control_files.sh
>
>
> Index: check_control_files.sh
> diff --git a/check_control_files.sh b/check_control_files.sh
> new file mode 100755
> index
>
0000000000000000000000000000000000000000..6f3364ad222bb45c33d12774c8f3d410d7e4b6cb
> --- /dev/null
> +++ b/check_control_files.sh
> @@ -0,0 +1,15 @@
> +#!/bin/bash
> +
> +# Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +# This script will check all existing AutoTest control files for
> correctness.
> +
> +. "$(dirname "$0")/common.sh"
> +
> +AUTOTEST_ROOT=${SRC_ROOT}/third_party/autotest/files
> +CHECKSCRIPT=${AUTOTEST_ROOT}/utils/check_control_file_vars.py
> +SITE_TESTS=${AUTOTEST_ROOT}/client/site_tests
> +
> +find $SITE_TESTS -maxdepth 2 -name control | xargs -n1 $CHECKSCRIPT
>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[ericli, 2010-06-18 00:47:43]

one nit, otherwise LGTM

http://codereview.chromium.org/2806016/diff/4001/5001
File check_control_files.sh (right):

http://codereview.chromium.org/2806016/diff/4001/5001#newcode3
check_control_files.sh:3: # Copyright (c) 2009 The Chromium OS Authors. All
rights reserved.
Copyright 2010