Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2806: This is just an idea for how to implement idle_timer which isn't yet feasible...

Created:
12 years, 3 months ago by dsh
Modified:
7 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This is just an idea for how to implement idle_timer which isn't yet feasible (I haven't even tried to compile this code because as soon as you pull in X11 headers, you get a bunch of name clashes), but it is good to get the approach reviewed first so I know if it's worth fixing things standing in its way. The code is similar to what is done in Pidgin, the GTK-based IM client, which is what I used for reference. There doesn't seem to be a good GTK API to use for finding the idle time, although there are idle-time callbacks. BUG=2183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -5 lines) Patch
M base/idle_timer.h View 4 chunks +19 lines, -4 lines 0 comments Download
M base/idle_timer.cc View 1 chunk +50 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dsh
This is NOT what I intend to commit. I haven't even tried to compile it ...
12 years, 3 months ago (2008-09-12 17:43:07 UTC) #1
darin (slow to review)
11 years, 10 months ago (2009-02-18 16:54:49 UTC) #2
cleaning up my review queue: is this patch still relevant?

Powered by Google App Engine
This is Rietveld 408576698