o3d-webgl: Adding support for triangle fan/strip in picking.

o3d-webgl: Adding support for triangle fan/strip in picking.

TEST=picking-more.html demo

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55017

[petersont, 2010-07-27 21:41:23]

http://codereview.chromium.org/2805101/diff/2001/3002
File samples/o3d-webgl/primitive.js (right):

http://codereview.chromium.org/2805101/diff/2001/3002#newcode337
samples/o3d-webgl/primitive.js:337:
o3d.Primitive.prototype.computeTriangleIndices =
Hm... how much work would it be to refactor this so that it didn't have to
allocate a new array?

[luchen, 2010-07-27 23:49:26]

http://codereview.chromium.org/2805101/diff/2001/3002
File samples/o3d-webgl/primitive.js (right):

http://codereview.chromium.org/2805101/diff/2001/3002#newcode337
samples/o3d-webgl/primitive.js:337:
o3d.Primitive.prototype.computeTriangleIndices =
On 2010/07/27 21:41:23, petersont wrote:
> Hm... how much work would it be to refactor this so that it didn't have to
> allocate a new array?
> 

Done. See if this looks any better? Moved the indexing logic elsewhere, so it
directly computes the relevant triangle triple instead of computing + storing.

[petersont, 2010-08-05 00:12:48]

lgtm.

[luchen, 2010-08-05 00:45:16]

Updated - doesn't create an index buffer if one is missing now either. Please
take another look (make sure my math is correct...), thanks.

[petersont, 2010-08-05 01:10:41]

http://codereview.chromium.org/2805101/diff/16001/17002
File samples/o3d-webgl/primitive.js (right):

http://codereview.chromium.org/2805101/diff/16001/17002#newcode399
samples/o3d-webgl/primitive.js:399: // TODO(luchen): Is it possible to pick
linestrips, linelists, etc.?
I shrug at this.  Gregg shrugs, too, I think it's a non-issue. :)

http://codereview.chromium.org/2805101/diff/16001/17002#newcode411
samples/o3d-webgl/primitive.js:411: switch (this.primitiveType) {
So, now I'm wondering if these functions can be defined outside
o3d.Primitive.prototype.intersectRay as separate, private members o3d.Primitive
or o3d.Primitive.prototype of  for a little extra efficiency.

[luchen, 2010-08-05 01:47:48]

Done. Give it a look?

On 2010/08/05 01:10:41, petersont wrote:
> http://codereview.chromium.org/2805101/diff/16001/17002
> File samples/o3d-webgl/primitive.js (right):
> 
> http://codereview.chromium.org/2805101/diff/16001/17002#newcode399
> samples/o3d-webgl/primitive.js:399: // TODO(luchen): Is it possible to pick
> linestrips, linelists, etc.?
> I shrug at this.  Gregg shrugs, too, I think it's a non-issue. :)
> 
> http://codereview.chromium.org/2805101/diff/16001/17002#newcode411
> samples/o3d-webgl/primitive.js:411: switch (this.primitiveType) {
> So, now I'm wondering if these functions can be defined outside
> o3d.Primitive.prototype.intersectRay as separate, private members
o3d.Primitive
> or o3d.Primitive.prototype of  for a little extra efficiency.

[petersont, 2010-08-05 02:07:04]

LGTM.